Apply Alpine thread stack size patch - #237
Merged
Merged
Conversation
This patch was OK'd by a Ruby maintainer (https://bugs.ruby-lang.org/issues/14387#note-16), but hasn't been merged because it isn't generic enough to support glibc properly, which doesn't matter here (since we're Alpine-only in this context).
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Oct 1, 2018
- `busybox`: 1.29.3, Buildroot 2018.08, Alpine 3.8 - `cassandra`: fix `cassandra.yaml` modification (docker-library/cassandra#160), `chown` fixes (docker-library/cassandra#158) - `ghost`: `chown` fixes (TryGhost/docker-library-ghost#153) - `julia`: 1.0.1 - `mariadb`: `chown` fixes (MariaDB/mariadb-docker#203) - `mongo`: `chown` fixes (docker-library/mongo#305) - `openjdk`: Oracle variants (docker-library/openjdk#235), 11 GA - `owncloud`: `chown` fixes (docker-library/owncloud#105) - `percona`: `chown` fixes (docker-library/percona#69) - `php`: 7.3.0RC2 - `rabbitmq`: `chown` fixes (docker-library/rabbitmq#281) - `redis`: `chown` fixes (redis/docker-library-redis#166) - `redmine`: `chown` fixes (docker-library/redmine#128) - `ruby`: Alpine thread stack size fix (docker-library/ruby#237) - `tomcat`: add JRE 11, remove EOL Tomcat 8.0 (docker-library/tomcat#133)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch was OK'd by a Ruby maintainer (https://bugs.ruby-lang.org/issues/14387#note-16), but hasn't been merged because it isn't generic enough to support glibc properly, which doesn't matter here (since we're Alpine-only in this context).
Closes #196
@ncopa do you see any issue with us applying this patch to all four currently supported versions (2.3, 2.4, 2.5, 2.6-rc)? The patch applies cleanly, so I was planning to just go for it assuming our basic "does Ruby appear to work properly?" smoke tests pass, but I'd appreciate your thoughts on whether that's safe to do