build: set local dirs as frontend attributes#2156
Merged
Merged
Conversation
crazy-max
force-pushed
the
frontend-attr-localdirs
branch
from
144d1b7 to
e3466d9
Compare
tonistiigi
reviewed
Dec 15, 2023
crazy-max
force-pushed
the
frontend-attr-localdirs
branch
3 times, most recently
from
8ef55c4 to
0f72361
Compare
crazy-max
force-pushed
the
frontend-attr-localdirs
branch
from
0f72361 to
7b4f991
Compare
tonistiigi
reviewed
Dec 19, 2023
crazy-max
force-pushed
the
frontend-attr-localdirs
branch
from
7b4f991 to
93ef603
Compare
Set local dirs metadata if relative to VCS directory so dockerfile path is tracked accurately in case vcs information is not fulfilled. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
frontend-attr-localdirs
branch
from
93ef603 to
02bc4e8
Compare
tonistiigi
approved these changes
Dec 22, 2023
cdupuis
approved these changes
Jan 3, 2024
Contributor
cdupuis
left a comment
cdupuis
left a comment
There was a problem hiding this comment.
This looks great. Thanks for the PR. It solves a big challenge for Scout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set local dirs metadata if relative to
workingVCS directory so dockerfile path is tracked accurately.