otel: create utility for storing common attributes for build options#2234
Closed
jsternberg wants to merge 1 commit into
Closed
otel: create utility for storing common attributes for build options#2234jsternberg wants to merge 1 commit into
jsternberg wants to merge 1 commit into
Conversation
Collaborator
Author
|
I have a few PRs that are going to use these attributes and have their code in common with each other. To prevent an issue where one of those PRs is blocked on another PR just because of these common changes, I separated it out into its own PR. |
jsternberg
force-pushed
the
build-attributes
branch
from
5a57047 to
f7d05c5
Compare
Adds a method to include common attributes for build related options when tracking build invocations. These attributes use certain parameters to the build command. This also refactors some of the utility methods used by the git tool to determine filepaths into its own separate package so they can be reused in another place. Also adds a test to ensure the resource is initialized correctly and doesn't error. The otel handler logging message is suppressed on buildx invocations so we never see the error if there's a problem with the schema url. It's so easy to mess up the schema url when upgrading OTEL that we need a proper test to make sure we haven't broken the functionality. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
build-attributes
branch
from
f7d05c5 to
8d5412a
Compare
Member
|
I reviewed this as part of #2225 . This separately is hard to review as it adds functions that don't get called and it is not clear how they would be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a method to include common attributes for build related options
when tracking build invocations. These attributes use certain parameters
to the build command.
This also refactors some of the utility methods used by the git tool to
determine filepaths into its own separate package so they can be reused
in another place.
Also adds a test to ensure the resource is initialized correctly and
doesn't error. The otel handler logging message is suppressed on buildx
invocations so we never see the error if there's a problem with the
schema url. It's so easy to mess up the schema url when upgrading OTEL
that we need a proper test to make sure we haven't broken the
functionality.