Skip to content

chore: remove unneeded excludes#3552

Merged
crazy-max merged 1 commit intodocker:masterfrom
jsternberg:remove-unneeded-excludes
Dec 5, 2025
Merged

chore: remove unneeded excludes#3552
crazy-max merged 1 commit intodocker:masterfrom
jsternberg:remove-unneeded-excludes

Conversation

@jsternberg
Copy link
Collaborator

The upstream PR that used the pseudo-versions was merged so this no
longer causes an upgrade of those dependencies to pseudo-versions so the
exclude is no longer needed.

Relates to #608.

The upstream PR that used the pseudo-versions was merged so this no
longer causes an upgrade of those dependencies to pseudo-versions so the
exclude is no longer needed.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, nice!

LGTM

@crazy-max crazy-max merged commit 22e7bf6 into docker:master Dec 5, 2025
139 checks passed
@thaJeztah
Copy link
Member

Was hoping we could remove it from Buildkit as well, but looks like github.com/containerd/accelerated-container-image still forces it; I recall I started working on that;

go mod graph | grep ' github.com/davecgh/go-spew@v1.1.2'
github.com/moby/buildkit github.com/davecgh/go-spew@v1.1.2-0.20180830191138-d8f796af33cc
github.com/containerd/accelerated-container-image@v1.3.0 github.com/davecgh/go-spew@v1.1.2-0.20180830191138-d8f796af33cc

@jsternberg jsternberg deleted the remove-unneeded-excludes branch December 5, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants