bake: sort extra-hosts before generating build options#3789
Open
crazy-max wants to merge 1 commit intodocker:masterfrom
Open
bake: sort extra-hosts before generating build options#3789crazy-max wants to merge 1 commit intodocker:masterfrom
crazy-max wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Member
|
Is the problem that the bake file uses a map (or similar)? Curious if we have a way to preserve the order in this they are defined. It may be a corner case, but (eg) in this case, order may matter because I think the first match is used; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3788
This change makes bake emit extra-hosts in a stable order before passing them into build options.