Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

docker / cli Public

Notifications You must be signed in to change notification settings
Fork 2.1k
Star 5.9k

Code
Issues 566
Pull requests 209
Discussions
Actions
Projects
Security and quality 2
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security and quality
Insights

Replace gometalinter with Golangci lint [carry 1797]#2173

Merged

thaJeztah merged 61 commits into

docker:masterdocker/cli:masterfrom

thaJeztah:carry_golangci_lintthaJeztah/cli:carry_golangci_lintCopy head branch name to clipboard

Oct 31, 2019

Conversation Commits61 (61)Checks Files changed

Merged

Replace gometalinter with Golangci lint [carry 1797]#2173
thaJeztah merged 61 commits into
docker:masterfrom
thaJeztah:carry_golangci_lint

Commits

Commits on Oct 31, 2019

opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result of append is never used, except maybe in other appends (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (sta…

silvin-lubecki
authored and
thaJeztah
committed
SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (staticcheck)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/trust/key_generate.go:112:9: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/stack/kubernetes/list.go:32:47: nilness: tautological condition: non-nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/container/start.go:157:20: nilness: nil dereference in type assertion (govet)

silvin-lubecki
authored and
thaJeztah
committed
cli/registry/client/fetcher.go:106:9: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
cli/compose/types/types.go:106:2: structtag: struct field tag `yaml:",inline", json:"-"` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet)

silvin-lubecki
authored and
thaJeztah
committed
opts/ulimit_test.go:11:13: composites: `*github.com/docker/cli/vendor/github.com/docker/go-units.Ulimit` composite literal uses unkeyed fields (govet)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/container/attach.go:141:15: nilness: impossible condition: nil != nil (govet)

silvin-lubecki
authored and
thaJeztah
committed
unchecked errors

silvin-lubecki
authored and
thaJeztah
committed
cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `dir` always receives `""` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/image/build/context_test.go:252:71: `createTestTempFile` - `perm` always receives `0777` (`511`) (unparam)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/image/build_session.go:133:45: getBuildSharedKey - result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/plugin/list_test.go:61:31: `TestList$1` - `filter` is unused (unparam)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/stack/kubernetes/deploy_test.go:65:68: `checkOwnerReferences` - `stackName` always receives `"test"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
cli/compose/convert: result 1 (error) is always nil (unparam)

silvin-lubecki
authored and
thaJeztah
committed
disable unparam linter on these functions, as we need an error in these function signatures

silvin-lubecki
authored and
thaJeztah
committed
compose/loader: define type for transformer-functions
thaJeztah
committed
Disable unparam linter: cli/required.go:102:16: `pluralize` - `word` always receives `"argument"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
Disable unparam linter: e2e/image/push_test.go:299:27: `withNotaryPassphrase` - `pwd` always receives `"foo"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
File is not `goimports`-ed (goimports)

silvin-lubecki
authored and
thaJeztah
committed
cli/compose/convert/service_test.go:274:72: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/registry/login_test.go:66:25: unnecessary conversion (unconvert)

silvin-lubecki
authored and
thaJeztah
committed
cli/command/image/build/context_test.go:244:38: `createTestTempDir` - `prefix` always receives `"builder-context-test"` (unparam)

silvin-lubecki
authored and
thaJeztah
committed
e2e/container: containerExistsWithStatus - t is unused (unparam)
thaJeztah
committed
cli/compose/convert: driverObjectConfig - result 1 (error) is always nil (unparam)
thaJeztah
committed
cli/command/secret: G101: Potential hardcoded credentials (gosec)
thaJeztah
committed
cli/command/service: SA1012: do not pass a nil Context (staticcheck)
thaJeztah
committed
cli/command/image/build: G107: Potential HTTP request made with variable url (gosec)
thaJeztah
committed
cli/command/trust: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
cli/command/utils: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
cli/command/image: SA1006: printf-style with no further arguments (staticcheck)
thaJeztah
committed
cli/context/store: SA5001: should check returned error before deferring f.Close() (staticcheck)
thaJeztah
committed
cli/command/formatter: Error return value of `ImageWrite` is not checked (errcheck)
thaJeztah
committed
cli/command: Error return value of `cli.Apply` is not checked (errcheck)
thaJeztah
committed
cli/command/formatter: Error return value of `ContainerWrite` is not checked (errcheck)
thaJeztah
committed
cli/config: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
service/logs: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
templates: Using the variable on range scope `testCase` in function literal (scopelint)
thaJeztah
committed
cli/compose/loader: Using a reference for the variable on range scope `overrideService` (scopelint)
thaJeztah
committed
e2e/cli-plugins: Using the variable on range scope `args` in function literal (scopelint)
thaJeztah
committed
cli/command/context: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
cli/command/trust: Using the variable on range scope `keyBytes` in function literal (scopelint)
thaJeztah
committed
cli/command: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
cli: remove unnecessary newlines (whitespace)
thaJeztah
committed
internal: remove unnecessary newlines (whitespace)
thaJeztah
committed
e2e: remove unnecessary trailing newline (whitespace)
thaJeztah
committed
cli/command/container: suppress dogsled warnings
thaJeztah
committed
cli/compose/template: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
cli/manifest: Using the variable on range scope `testcase` in function literal (scopelint)
thaJeztah
committed
opts: Using the variable on range scope `tc` in function literal (scopelint)
thaJeztah
committed
cli/command/stack/kubernetes: Using a reference for the variable on range scope `obj` (scopelint)
thaJeztah
committed
cli/command/container: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
cli/command/stack/kubernetes: Using the variable on range scope `c` in function literal (scopelint)
thaJeztah
committed
service: remove unused opts from newService() (unparam)
thaJeztah
committed
Remove now obsolete gometalinter and use golangci-lint instead

silvin-lubecki
authored and
thaJeztah
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.