Add script to regenerate test-certificate fixtures#2429
Merged
Conversation
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
Shouldn't this script be called somewhere ? 🤔
Member
Author
|
Right now it's to manually update the certificates; we could generate them "on the fly" it we want to (still have to wait for the changes to be merged upstream) 😅 |
AkihiroSuda
reviewed
Apr 10, 2020
| #!/usr/bin/env sh | ||
|
|
||
| GO111MODULE=off go get -u github.com/dmcgowan/quicktls | ||
| cd notary || exit 1 |
Collaborator
There was a problem hiding this comment.
set -eu instead of exit 1?
Member
Author
There was a problem hiding this comment.
Ah, yes, I think that works as well; this was mostly to satisfy the linter 😅
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
add_fixture_gen_script
branch
from
77d5615 to
3b256db
Compare
Member
Author
|
Updated; PTAL |
AkihiroSuda
approved these changes
Apr 10, 2020
tiborvass
approved these changes
Apr 11, 2020
Member
Author
|
bringing this one in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #2428
depends on dmcgowan/quicktls#3