Add bash completion for docker trust commands#609
Merged
Conversation
Removes a copy & paste leftover. Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
thaJeztah
added
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
Member
|
IIRC, we marked these commands "experimental" (which is a bit tricky, because it's a client-side only feature, so we don't currently hide them). I don't see a real harm in including them in the completion scripts (as 17.10 is an edge release, so no long-term consequences) @riyazdf PTAL |
Collaborator
Author
|
@thaJeztah The commands are only considered in bash completion if the CLI runs against an experimental server. |
|
awesome, thanks @albers! I am not familiar with how bash completion works so it'd be best if someone else can provide review/approval here. |
Member
|
ah, yes, I forgot for a minute we added the check for experimental here as well 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds bash completion for #472.
This should go into 17.10.0 because the feature is present in that release.