Update bash completion and deprecation for synchronous service updates#610
Merged
Merged
Conversation
The default value for `docker service create|update|scale|rollback --detach|-d` changed from `true` to `false`. This updates bash completion to complete just `--detach|-d`. Signed-off-by: Harald Albers <github@albersweb.de>
- The default was not changed in 17.09 but will be in 17.10 - `service scale` and `service rollback` are also affected. Signed-off-by: Harald Albers <github@albersweb.de>
albers
requested review from
mdlinville,
thaJeztah and
vdemeester
as code owners
thaJeztah
added
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value for
docker service create|update|scale|rollback --detach|-dchanged fromtruetofalse.This updates bash completion to complete just
--detach|-d.This should go into 17.10.0 because the behavior changes in this release.
Also updates the deprecation of asynchronous service updates:
service scaleandservice rollbackare also affected.