image push: respect NO_COLOR in aux notes#6957
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
vvoland
left a comment
There was a problem hiding this comment.
Thanks, your commit sign-off needs a real name though.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
@WilliamK112 can you fix the sign-off message in the commit to use your real name and e-mail? (Ching Wei Kang) instead of your GitHub handle? Here's some instructions, but let me know if you need more info: We require all commit messages to have a There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Let me know if you need help or more detailed instructions! |
Summary
docker image pushaux-note coloring throughtui.OutputNO_COLORwhen rendering the digest mapping noteNO_COLOR=1Why
Fixes
docker image pushemitting ANSI color codes in aux-note output even whenNO_COLORis set.Fixes #6890
Testing
TestRunPushRespectsNoColorForAuxNotesgit diff --checkgois not installed in PATH here; CI should validate compile/test behavior