[BUG] `up` Incorrectly recreates containers with no changes

[thedanbob]

Description

Since updating to 2.16, docker compose up incorrectly recreates containers when they haven't changed. This only appears to happen for services that are defined in another file and included with extends.

Steps To Reproduce

1. Define a service in a separate YAML file and include the file in docker-compose.yml with extends
2. Run docker compose up -d multiple times
3. Service will recreate+start each time

Compose Version

Docker Compose version 2.16.0

Docker Environment

No response

Anything else?

No response

[tanpro260196]

This happens to me too, without extend, any time a service gets an image update, docker compose up always recreate the container even though it's already running the newest image.

One workaround is to manually docker compose down first then docker compose up again.

[songyantao0617]

An easy way to reproduct this issue

version: '3.8'
services:
  foo:
    environment:
      - name=value
    image: ubuntu
    command: tail -f /dev/null

run docker compose up foo -d over and over again , it is normal as previous version. no recreate happend after it has been already created.
But ! , if any change was made in docker-compose.yml ,such as:

version: '3.8'
services:
  foo:
    environment:
      - name=xxxxxxxxxx
    image: ubuntu
    command: tail -f /dev/null

after then no metter how many times you run docker compose up foo -d , the compose will alway recreate the container!

'2.16.0' has this problem

Hope the core developers could notice this issue.

[KeldorDE]

I can confirm the bug. On multiple systems, the containers are restarted on each docker composer up if a new image update was previously downloaded.

[thedanbob]

This happens to me too, without extend, any time a service gets an image update, docker compose up always recreate the container even though it's already running the newest image.

I can confirm the bug. On multiple systems, the containers are restarted on each docker composer up if a new image update was previously downloaded.

Ah! This must be the real bug then, not extends. I noticed that not every service with extends would get recreated at first, but looking back it was definitely the ones with image updates. However, I did notice that docker compose up -d <service> would recreate the image even with no new image or service file change, so maybe extends factors into that. Or maybe that's a separate bug altogether.

[alfonx]

I can confirm this bug for 2.16, too: "docker compose up -d" recreates all containers always. I do not use extends.
Downgrading to docker-compose-plugin=2.15.1 it works again as expected (only recreates when there is a change)

[milas]

There was a regression in v2.16.0 that's fixed by #10275 which would cause Compose to keep re-creating containers unnecessarily on up after the first time.

This will be fixed in the next Compose release.

[fede843]

thanks!

[AnderssonPeter]

Hi I'm having a similar issue but I'm unsure if the fix will work or not..
Docker version: 23.0.1
Docker compose version: v2.16.0

And docker compose seems to recreate my containers for ever if it detects a change once...

1. Initial start
2. Second start no changes (Works as expected the container is not recreated)
3. Start with changes (Works as expected the container is recreated)
4. Start with no changes (Does not work as expected Recreates it)
   No matter how many times I run docker compose up -d --wait it just keeps recreating them, the only workaround seems to be to run docker compose down every time I make a change then it starts working as expected until the next change is made.

Just a theory is the hash only updated on the initial docker compose start? (where is the hash stored?)

[KeldorDE]

@AnderssonPeter Please retry with docker compose version 2.17.0
The bug was fixed in this version. After you run docker compose up one more time, the containers will be created again, after that the bug should not occur anymore.