Skip to content

show logs on watch#11511

Closed
gabilaza wants to merge 1 commit into
docker:mainfrom
gabilaza:11089-watch-logs
Closed

show logs on watch#11511
gabilaza wants to merge 1 commit into
docker:mainfrom
gabilaza:11089-watch-logs

Conversation

@gabilaza
Copy link
Copy Markdown

What I did
Show logs for containers on compose watch with the logs flag, and include related flags for logs such as color, prefix, and timestamp.

Related issue
#11089

Why I did
I believe that the 'compose watch' command is not complete without logs.

(not mandatory) A picture of a cute animal, if possible in relation to what you did
Cute-Baby-Owl-Bird-Watercolor-Clip-art-Graphics-82135327-1-1-580x435

Signed-off-by: Gabriel Laza <gabriellaza02@gmail.com>
@ndeloof
Copy link
Copy Markdown
Contributor

ndeloof commented Feb 19, 2024

Thanks for looking into this.
I've been working on this same topic from another angle: adding watch feature inside up command: #11525
Could you please give it a try and let me know if this would cover your needs ?

@gabilaza
Copy link
Copy Markdown
Author

LGTM with the --watch option for up. I'm not sure if you noticed, but there are overlapping logs when recreating the container after rebuilding in your demo. I made a case where the container just builds something and exits with the build status and I noticed a problem: the following containers didn't show the logs. Perhaps the last issue will be fixed if the tests pass. I didn't look that deeply into the failed test to see if that's the problem.

@ndeloof
Copy link
Copy Markdown
Contributor

ndeloof commented Feb 19, 2024

there are overlapping logs when recreating the container after rebuilding in your demo

yes, the recreate progress UI interacts with the logs, need to fix this

@gabilaza gabilaza closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants