only check for env_file#13402
Merged
Merged
Conversation
ndeloof
force-pushed
the
publish_env
branch
3 times, most recently
from
d5e011a to
9e7ddb6
Compare
Contributor
Author
|
@glours I'm not sure why we introduced those checks in the first place, as we don't actually publish interpolated values, and we use scanner to detect hard-coded sensitive data. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Contributor
|
@ndeloof IIRC, the env check was done before we introduced the secret scanner, and I forgot to remove the unnecessary controls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
as we publish the raw compose.yaml, there's no need to reject use of environment: the actual value from published environment won't be published. The only env var we could publish are those from env_file(s)
Related issue
fixes #13394
(not mandatory) A picture of a cute animal, if possible in relation to what you did