Touchup "Extending services in Compose"#1993
Closed
charleswhchan wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Charles Chan <charleswhchan@users.noreply.github.com>
charleswhchan
force-pushed
the
patch-2
branch
from
583b1f0 to
cad66a1
Compare
|
Thanks for the contribution! In my opinion, this guide is going to need to change significantly as a result of #2051, since the process of configuring an app for multiple environments should now be simplified. Perhaps we should incorporate some of these changes when revising it. |
|
Ya, I'm about to start working on #2141 which will make significant changes to this section. I'll cherry-pick this commit first and try and preserve some of the edits. |
Author
|
Thanks @dnephin. |
|
The new version is out. I tried to incorporate some of these changes. It did change pretty drastically, so I wasn't able to apply the cherry-pick, but hopefully the new version is better. Thanks again for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(The rendered version, if it's easier for review:
https://github.com/charleswhchan/compose/blob/patch-2/docs/extends.md)