Allow using docker-compose.yml.dist#1999
Conversation
Signed-off-by: iamluc <luc@vieillescazes.net>
Signed-off-by: iamluc <luc@vieillescazes.net>
|
First impression: nice, I like it 👍 |
|
Since this is a new convention, I think it's going to require some discussion. My initial impression is that it might be good to support some kind of fallback (in addition to the "legacy filename" fallbacks we already do). I'm not sure what the filenames should be, or if we should actually make it configurable. #745 proposed supporting a If we don't allow it to be configurable, I'd prefer to keep the It's also worth mentioning that this can be accomplished pretty easily within a team or organization with a bash script wrapper and |
Sure, but wrappers are often a pain because they are differents on each projects: path/name, options, etc... |
|
Yes, adding a wrapper is easy to do, but having it "officially" in compose will add to a standardized way to distribute a compose app (in stead of each project using their own way). I think if a |
|
See #1987 (comment) for an alternative solution which also serves the multi-environment use case. |
|
Closing this as we now have the alternative solution done here #2051 |
Having one
docker-compose.ymlfile in a project can sometime lead to conflicts with others developers as we all need to adapt it to our needs (ports, volumes, environments, etc..).With this PR, I suggest to allow compose to look at
docker-compose.yml.distifdocker-compose.ymldoes not exist.So the
.distfile can be added to the VCS of the project, but can still be overrided by creating the filedocker-compose.yml(excluded in the VCS).This strategy is used for example by phpunit