Build from url#2430
Merged
Merged
Conversation
dnephin
force-pushed
the
build_from_url
branch
from
04ada2f to
fb315c6
Compare
There was a problem hiding this comment.
This variable should probably be called something different
|
Great stuff. |
Signed-off-by: Jonas Eckerström <jonaseck@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin
force-pushed
the
build_from_url
branch
from
fb315c6 to
2ab3cb2
Compare
Author
|
Updated with those changes |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased #1372 and added more tests and docs
Fixes #491