Support for build arguments#2653
Merged
Merged
Conversation
|
Looks like there is a test failure |
Allows 'build' configuration option to be specified as an object and adds support for build args. Signed-off-by: Garrett Heel <garrettheel@gmail.com>
Made invalid in v2 format Doesn't break build config anymore Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
Runscope-build-args
branch
2 times, most recently
from
fb0ea0e to
ddeaf24
Compare
There was a problem hiding this comment.
I think you had deleted this in a previous rebase, right? Now that it's in the V1 function
shin-
force-pushed
the
Runscope-build-args
branch
from
ddeaf24 to
768a977
Compare
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
Runscope-build-args
branch
from
768a977 to
1ae57d9
Compare
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #2540
Resolved merge conflicts + small change to move legacy format handling in the appropriate method.