Skip to content

Add target property to build#5011

Merged
shin- merged 2 commits into
docker:masterfrom
lawliet89:build-target
Jul 21, 2017
Merged

Add target property to build#5011
shin- merged 2 commits into
docker:masterfrom
lawliet89:build-target

Conversation

@lawliet89
Copy link
Copy Markdown

Fixes #4790

I had to introduce a new v2.3 Compose format to implement this.

@shin- shin- added this to the 1.16.0 milestone Jul 11, 2017
Signed-off-by: Yong Wen Chua <me@yongwen.xyz>
Signed-off-by: Yong Wen Chua <me@yongwen.xyz>
@philtay
Copy link
Copy Markdown

philtay commented Jul 12, 2017

@dnephin I think this should be added to v3 as well.

Copy link
Copy Markdown

@shin- shin- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shin- shin- merged commit 1ecf51c into docker:master Jul 21, 2017
@lawliet89 lawliet89 deleted the build-target branch July 21, 2017 02:14
@sirlatrom
Copy link
Copy Markdown

Will this also be in a spec version 3.4? I know 3.x ignores and does not support the build option, but having target supported would allow having just one docker-compose.yml file.

@dnephin
Copy link
Copy Markdown

dnephin commented Aug 9, 2017

docker/cli#430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants