Skip to content

Fix bind mounts when in project volumes definition#9514

Merged
glours merged 1 commit into
docker:v2from
ulyssessouza:fix-bindmounts
Jun 9, 2022
Merged

Fix bind mounts when in project volumes definition#9514
glours merged 1 commit into
docker:v2from
ulyssessouza:fix-bindmounts

Conversation

@ulyssessouza
Copy link
Copy Markdown
Contributor

What I did
Fix bind mounts when in project volumes definition

This fixes the type of a volume back to a bind mount

Related issue
Resolves docker/for-mac#6317

@ulyssessouza ulyssessouza requested review from glours and ndeloof May 31, 2022 13:00
Comment thread pkg/compose/create.go Outdated
Comment thread cmd/compose/compose.go Outdated
@ulyssessouza ulyssessouza force-pushed the fix-bindmounts branch 3 times, most recently from 668eadf to 0ba4604 Compare June 1, 2022 21:52
@ulyssessouza ulyssessouza requested a review from ndeloof June 1, 2022 21:53
@ulyssessouza ulyssessouza force-pushed the fix-bindmounts branch 2 times, most recently from 3baaf42 to caa88b2 Compare June 1, 2022 22:22
@ulyssessouza ulyssessouza marked this pull request as ready for review June 1, 2022 22:29
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Copy link
Copy Markdown
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device Bind Mount Disconnecting from Container Directory

4 participants