Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

deb: simplify cleaning up after apt-get update/install#220

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:simplify_cleanup
Feb 23, 2021
Merged

deb: simplify cleaning up after apt-get update/install#220
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:simplify_cleanup

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Feb 19, 2021

follow-up to #219 (I'll rebase once that's merged) rebased

Running apt-cache clean and/or removing /var/cache/apt will be a
no-op in most cases (or at least will provide very little differences).

This patch simplifies the cleanup steps, and only keeps steps to remove
package list information (where possible).

Thanks to Tianon Gravi, who pointed out that this is not needed <3

tianon
tianon previously approved these changes Feb 19, 2021
Copy link
Copy Markdown
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤘

Running `apt-cache clean` and/or removing `/var/cache/apt` will be a
no-op in most cases (or at least will provide very little differences).

This patch simplifies the cleanup steps, and only keeps steps to remove
package list information (where possible).

Thanks to Tianon Gravi, who pointed out that this is not needed <3

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review February 23, 2021 08:20
@thaJeztah
Copy link
Copy Markdown
Member Author

@silvin-lubecki @StefanScherer ptal

Copy link
Copy Markdown
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

bringing this one in

@thaJeztah thaJeztah merged commit ac37a9d into docker:master Feb 23, 2021
@thaJeztah thaJeztah deleted the simplify_cleanup branch February 23, 2021 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants