Skip to content

deb: make dh-systemd dependency optional as it's deprecated#520

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:fix_build_dep
Feb 19, 2021
Merged

deb: make dh-systemd dependency optional as it's deprecated#520
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:fix_build_dep

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

dh-systemd has been integrated into debhelper, starting with version 9.20160709, and has been removed in Debian 11 "bullseye"

This patch updates the control file to not require it as a dependency on current versions of debian that ship with that version of debhelper

Related discussions:

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822670
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958585

@thaJeztah
Copy link
Copy Markdown
Member Author

@silvin-lubecki @tianon PTAL

Comment thread deb/common/control Outdated
dh-systemd has been integrated into debhelper, starting with version 9.20160709,
and has been removed in Debian 11 "bullseye"

This patch updates the control file to not require it as a dependency
on current versions of debian that ship with that version of debhelper

Related discussions:

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822670
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958585

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

@silvin-lubecki @chris-crone ptal

Copy link
Copy Markdown
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Let me bring this one in

@thaJeztah thaJeztah merged commit 6929936 into docker:master Feb 19, 2021
@thaJeztah thaJeztah deleted the fix_build_dep branch February 19, 2021 13:36
@thaJeztah
Copy link
Copy Markdown
Member Author

(and dropping --with systemd in deb/common/rules, which needs to be tested but should work)

Oh, forgot looking into that part; let me open up a follow-up so that we can test if it's no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants