[20.10 backport] Add workaround for CentOS 7 not working without GOPROXY#619
Merged
thaJeztah merged 1 commit intoFeb 8, 2022
Merged
Conversation
This fix was previously included in the rootlesskit install script in moby, but should've been addressed by Go 1.14 and up. Unfortunately, this does not appear the case, and go modules without proxy is still broken on older versions of git, such as the version of git used by CentOS 7. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 9c363de) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
rumpl
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #577
this is not needed (yet), but some changes may be back ported in upstream moby/moby that may cause this to be a problem, so let's prepare for that (moby/moby#42674)
This fix was previously included in the rootlesskit install script
in moby, but should've been addressed by Go 1.14 and up. Unfortunately,
this does not appear the case, and go modules without proxy is still
broken on older versions of git, such as the version of git used by
CentOS 7.
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit 9c363de)
Signed-off-by: Sebastiaan van Stijn github@gone.nl