Caller of cred helpers would now see the stderr returns from cred helpers#64
Merged
Conversation
…pers Signed-off-by: shhsu@microsoft.com <shhsu@microsoft.com>
Author
|
@sajayantony @DavidObando @sivagms @friism, this is related to the redesign of docker/cli#105. To clarify: we are implementing an azure credential helper that handles the azure login interactively. |
Contributor
|
LGTM |
Author
|
thanks @n4ss |
vdemeester
approved these changes
May 26, 2017
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
Should I be expecting a merge when more people have approved the PR or can we go ahead and merge?
@shhsu yes, at least 2 ppl needs to approve a PR for it getting merge 👼
LGTM 🐸
Author
|
thanks @vdemeester |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of our design for Azure Docker Registry, we found that it would be useful (necessary for us) for cred manager to pipe it's stderr back to cli client. Hence this PR.