Move "docker-for-windows" and "docker-for-mac" inside the "desktop" directory#13353
Conversation
Unifying all content related to Docker Desktop to be withing the desktop directory. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Unifying all content related to Docker Desktop to be withing the desktop directory. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
This will likely conflict with #13352 and #13351, but I can rebase after those are merged @usha-mandya @StefanScherer ptal (probably best to keep this one for after the weekend in case fix-ups are needed) |
|
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: 346a066 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/6117c03b46352800083c4fa4 😎 Browse the preview: https://deploy-preview-13353--docsdocker.netlify.app |
|
Overall a good idea. But I remember we had problems with redirects with anchors. Currently I can find these links with anchors that are used in DD up to 3.6.0:
|
|
Yes, I already opened a PR to update the links; https://github.com/docker/pinata/pull/16249, but ideally we should change all links in DD itself to use |
|
Thanks that you already thought about the changes in pinata, the PR looks good! For this PR I think it's the best what we can do for older DD versions (anchors not working), but with 4.0.0 we have it corrected again. So I'm fine with merging this PR anytime before 4.0.0. |
The |
|
Thank you @thaJeztah. LGTM |
|
@thaJeztah Are we good to merge this, or should we wait until the Pinata PR is ready to go live? |
Yup! Checked internally, and all links from Docker Desktop open in a browser, so should redirect as usual |
This brings all desktop-related content into a single directory;
This makes the URLs more consistent/predictable, and easier to navigate.