dockerfile: new reference location#14948
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
1e5c48a to
267d3c0
Compare
|
|
||
| - A link to an auto-generated reference page that we pull in during docs builds: | ||
| [/engine/reference/builder/#env](/engine/reference/builder/#env). | ||
| [/dockerfile/reference/#env](/dockerfile/reference/#env). |
There was a problem hiding this comment.
Perhaps we should start to consider using /reference/xxxx again for URLs instead;
/reference/dockerfile//reference/commandline/xxxetc
There was a problem hiding this comment.
Keeping in /engine/reference/builder/ for now. Let's do the slug change in a follow-up.
267d3c0 to
a67f515
Compare
a67f515 to
4dec9e3
Compare
|
@thaJeztah As discussed on Slack, we don't fetch from a release branch but master branch of the BuildKit repository for reference docs. Will open a follow-up PR on BuildKit to mark new features as suggested. I have started to work on the Dockerfile reference changelog that will be on this repo in a dedicated page so we can cross-link with sections in reference docs but we need to first update the slug as the Dockerfile reference is not a section atm: |
4dec9e3 to
aa0dd60
Compare
|
Simplified this PR now that #14799 is merged. No need extra plugin to move pages around as the correct reference is picked up by fetch remote plugin to create edit and issue link: https://deploy-preview-14948--docsdocker.netlify.app/engine/reference/builder/ |
aa0dd60 to
136854a
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
136854a to
f299b0b
Compare
|
@thaJeztah are we good to merge this PR? Thanks |
needs moby/buildkit#2902Dockerfile reference is now located in the BuildKit repository.
Preview: https://deploy-preview-14948--docsdocker.netlify.app/engine/reference/builder/
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com