Addition of a 'Contribute' section with our Style Guide#15350
Merged
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
dvdksn
reviewed
Sep 2, 2022
| - Column and row headers in tables | ||
| - Links | ||
| - Sentences (of course) | ||
| - Anything in the Ul including navigation labels, buttons, headings |
Contributor
There was a problem hiding this comment.
Suggested change
| - Anything in the Ul including navigation labels, buttons, headings | |
| - Anything in the Ul including navigation labels, buttons, headings. Provided that the corresponding UI label uses sentence case; follow the capitalization style of the UI element. |
Comment on lines
+154
to
+155
| - Use the em dash (-) sparingly when you want the reader to pause, to create parenthetical statements, or to emphasize specific words or phrases. Always put a space on either side of the em dash. | ||
| - Use an en dash (-) to indicate spans of numbers, dates, or time. |
Contributor
There was a problem hiding this comment.
Finally I know which one to use where 👍🏻 :-D
dvdksn
reviewed
Sep 2, 2022
| path: /contribute/overview/ | ||
| node: contribute | ||
| # TODO unify navbbar links: homepage currently has a custom "articles" link | ||
| hide_home: true |
Contributor
There was a problem hiding this comment.
I don't think we should hide the contribute section from the landing page. But, it looks like that would also require some CSS changes, too. The home page already contains the additional "Articles" link, and adding contribute as well makes it rather wide. The media query looks like it's set to collapse the nav menu at 768px, which is narrower than the width of the navbar if we also add contribute.
Easy solution would be to remove the Articles (blog) link. Do we really need it? :D
Contributor
|
Also we might want to update CONTRIBUTING.md, and just put a link to the contribution section in there. I think that's better than removing the file entirely. |
aevesdocker
changed the title
aevesdocker
added a commit
that referenced
this pull request
Sep 5, 2022
* Update mac-install.md (#15555) Typo in spelling of subscription. `subscri[tion` -> `subscription` * Addition of a 'Contribute' section with our Style Guide (#15350) * SG test. * moved some content around * editing * broken links fix * formatting changes * fixes * fixes * edits after review * fix broken links * broken link fix * a few more edits * removed contributing page * Revert "removed contributing page" This reverts commit 5822cd5. * add redirect * Install page improvement based on feedback (scenario2) (#15494) * Install page improvement based on users and PM feedback * Exploring a second scenario deriving from additional feedback * Review feedback * contribute edit (#15565) Co-authored-by: Clint Joseph <clintjoseph1992@gmail.com> Co-authored-by: Dockertopia <103652162+dockertopia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.