added link target for legacy system requirements location - #1947
Merged
Conversation
…o new location Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Contributor
Author
|
LGTM, merging to address this issue in published docs ASAP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
added link target (id) for legacy location of system requirements for Docker for Mac and Windows so that hard-coded links in template responses to certain classes of bug report reference won't break
updated the note in Docker for Mac and Windows home pages to x-ref specifically to system requirements in the install page, and say that the topic moved there.
directly fixed the links on the install pages for both Mac and Windows to link to the on-page topic system requirements (that was a mistake in previous link updates I made in the docs, not the same problem as in the templates)
Explanation: The links breaking in the app templates is due to the fact that we restructured all the docs to split out install topics (
install.mdfrom the rest of the getting started (index.md). The above updates should catch the template links at the note. At some point, if you want to modify the link fromindex.md#what-to-know-before-installtoinstall.md#what-to-know-before-install, then those links would go directly to the topic.Related issues
https://github.com/docker/pinata/issues/6624
Reviewers
@ijc25 @friism @jeanlaurent @ebriney
Signed-off-by: Victoria Bialas victoria.bialas@docker.com