bake: remote auth variables#19749
Merged
Merged
Conversation
github-actions
Bot
added
the
area/build
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
force-pushed
the
bake-auth-remote-def
branch
from
41ddff3 to
4dae1d0
Compare
dvdksn
added
the
status/do-not-merge
crazy-max
previously approved these changes
Apr 8, 2024
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
LGTM
Was also wondering if we should put the supported buildx version for our variables?
Contributor
Author
|
ah yes good point. |
dvdksn
force-pushed
the
bake-auth-remote-def
branch
from
4dae1d0 to
b593c3d
Compare
crazy-max
previously approved these changes
Apr 8, 2024
crazy-max
reviewed
Apr 15, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
bake-auth-remote-def
branch
from
b593c3d to
b0847cd
Compare
crazy-max
approved these changes
Apr 17, 2024
crazy-max
removed
the
status/do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new variables for preflight auth when using remote bake definitions in private repos
https://deploy-preview-19749--docsdocker.netlify.app/build/building/variables/#buildx_bake_git_auth_header
Related issues or tickets
docker/buildx#2363
Reviews