docs: document sandbox environment variables - #25790
Conversation
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
Documents the new -e/--env-file flags for sbx run and sbx create (v0.39.0+). Content is accurate and well-structured. Three issues found: one confirmed grammar error and two clarity issues introduced by the PR.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The PR consolidates environment-variable documentation into usage.md, updates the Claude Code + Model Runner guide to use the new -e flag on sbx create, and removes the duplicate FAQ entry. The changes are clean, well-scoped, and consistent with the style guide.
No high or medium severity issues were found.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The PR consolidates sandbox environment-variable documentation cleanly: the new Set environment variables section in usage.md explains precedence and lifecycle clearly, the Claude Code guide is simplified by moving ANTHROPIC_BASE_URL into sbx create, and kit-examples.md is updated to point to the new section. No broken links, missing redirects, vendored-file edits, or AI-isms detected. Two minor findings noted inline.
Sandbox users had to modify an internal persistent shell file to set custom environment variables. Document the v0.39.0 environment flags, their precedence and lifecycle behavior, and update affected examples to use them.
The FAQ duplicated environment-variable instructions that now belong in the command-oriented usage page. Move the persistent-shell guidance there and distinguish ordinary variables from proxy-managed service and custom secrets.
The Model Runner guide contained a grammatical error and an unclear reason for creating before running. Clarify that verification flow and distinguish the 1Password env-file option from the sbx flag while preserving proxy-managed credential behavior.
The environment-variable caveat distracted from the 1Password workflow and repeated material from the usage page. Remove the aside and identify the multi-credential example as an op run environment-file workflow.
The 1Password environment-file example is correct and outside the scope of the sbx environment flag documentation. Restore the section to its original wording.
The rebased FAQ update documented that persisted variables only reach newly started sessions and agents. Keep the FAQ discoverable and add the same operational caveat to the canonical usage procedure.
99beb37 to
6f1065d
Compare
2 participants
Summary
Document the
sbx runandsbx createenvironment-variable flags introduced in v0.39.0, including precedence and lifecycle behavior. Consolidate environment guidance in the Usage page, retain the persistent-shell option for existing sandboxes, distinguish ordinary variables from proxy-managed secrets, and update affected examples.@netlify /ai/sandboxes/usage/
Generated by Codex