Skip to content

downgrade Go version from 1.26.0 to 1.25.8 #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilopezluna merged 1 commit into from
Mar 17, 2026
Merged

downgrade Go version from 1.26.0 to 1.25.8 #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417
with:
go-version: 1.26.0
go-version: 1.25.8
cache: true

- name: Install golangci-lint
Expand All @@ -45,7 +45,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417
with:
go-version: 1.26.0
go-version: 1.25.8
cache: true

- name: Check go mod tidy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417
with:
go-version: 1.26.0
go-version: 1.25.8
cache: true

- name: Set up Docker Buildx
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417
with:
go-version: 1.26.0
go-version: 1.25.8
cache: true

- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1

ARG GO_VERSION=1.26
ARG GO_VERSION=1.25
Comment thread
ilopezluna marked this conversation as resolved.
ARG LLAMA_SERVER_VERSION=latest
ARG LLAMA_SERVER_VARIANT=cpu
ARG LLAMA_BINARY_PATH=/com.docker.llama-server.native.linux.${LLAMA_SERVER_VARIANT}.${TARGETARCH}
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Project variables
APP_NAME := model-runner
GO_VERSION := 1.26.0
GO_VERSION := 1.25.8
Comment thread
ilopezluna marked this conversation as resolved.
LLAMA_SERVER_VERSION := latest
LLAMA_SERVER_VARIANT := cpu
BASE_IMAGE := ubuntu:24.04
Expand Down
2 changes: 1 addition & 1 deletion cmd/cli/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1

ARG GO_VERSION=1.26
ARG GO_VERSION=1.25
Comment thread
ilopezluna marked this conversation as resolved.
ARG ALPINE_VERSION=3.23

ARG DOCS_FORMATS="md,yaml"
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/docker/model-runner

go 1.26.0
go 1.25.8
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The go directive should use only major.minor (e.g., go 1.25) rather than a full patch version.

Using a patch version in go.mod will cause go tooling errors (e.g., invalid go version). Please change this to go 1.25 and keep the specific patch level (1.25.8) enforced via CI/Docker or other tooling instead.

Comment thread
ilopezluna marked this conversation as resolved.

require (
github.com/charmbracelet/glamour v1.0.0
Expand Down
Loading