Skip to content

fix: use rm -f to handle missing .py files in llamacpp install #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericcurtin merged 1 commit into from
May 21, 2026
+1 −1
Merged

fix: use rm -f to handle missing .py files in llamacpp install #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llamacpp/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ ifeq ($(DETECTED_OS),macOS)
--config Release \
--prefix $(INSTALL_DIR)
@echo "Cleaning install directory..."
rm $(INSTALL_DIR)/bin/*.py
rm -f $(INSTALL_DIR)/bin/*.py
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The path should be quoted to handle cases where $(INSTALL_DIR) contains spaces. Unquoted paths in shell commands can lead to incorrect file deletion or command failure if the directory name contains whitespace. This aligns with the repository's focus on correctness and safety (Repository Style Guide, line 24).

	rm -f "$(INSTALL_DIR)/bin/"*.py
References
  1. The repository style guide prioritizes correctness and safety. Unquoted paths in shell commands are a common source of bugs and safety issues when directory names contain spaces. (link)

rm -rf $(INSTALL_DIR)/lib/cmake
rm -rf $(INSTALL_DIR)/lib/pkgconfig
rm -rf $(INSTALL_DIR)/include
Expand Down