fix: handle failed embed fetches and falsy cached() returns - #2774
Closed
Diawhiz wants to merge 4 commits into
Closed
fix: handle failed embed fetches and falsy cached() returns #2774Diawhiz wants to merge 4 commits into
Diawhiz wants to merge 4 commits into
Conversation
- embed.js: add error handler to get().then() so a failed :include
fetch calls next('') instead of silently stalling page rendering
- core/util/core.js: use instead of in
cached() so functions that legitimately return falsy values ('' or 0)
have their results stored and reused correctly
|
@Diawhiz is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
none |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: