Skip to content

Replace Metadata with AndroidConfig and AppleConfig#100

Merged
enfipy merged 3 commits intomainfrom
cargo-metadata
Jul 10, 2022
Merged

Replace Metadata with AndroidConfig and AppleConfig#100
enfipy merged 3 commits intomainfrom
cargo-metadata

Conversation

@Heezay
Copy link
Contributor

@Heezay Heezay commented Jul 7, 2022

  1. Metadata was separated into AndroidConfig and AppleConfig and placed into crossbundle/cli/commands/types.
  2. gen_android_manifest() and gen_minimal_android_manifest was moved out from the Impl block and made static methods.
  3. Fixed other bugs

@Heezay Heezay added the enhancement New feature or request label Jul 7, 2022
@Heezay Heezay self-assigned this Jul 7, 2022
@Heezay Heezay requested a review from enfipy July 10, 2022 11:28
@enfipy enfipy changed the base branch from main to add-plugin-support July 10, 2022 11:29
@enfipy enfipy changed the base branch from add-plugin-support to main July 10, 2022 11:45
enfipy
enfipy approved these changes Jul 10, 2022
View reviewed changes
Copy link
Collaborator

@enfipy enfipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has some flows with AppleConfig but LGTM for now.

@enfipy enfipy merged commit b48db95 into main Jul 10, 2022
@enfipy enfipy deleted the cargo-metadata branch July 10, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enfipy enfipy enfipy approved these changes

Assignees

@Heezay Heezay

Labels

enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Heezay @enfipy