Fix warnings in AdMob plugin and PermissionsUtil#129
Merged
enfipy merged 7 commits intomanifest-permissionsfrom Aug 3, 2022
Merged
Fix warnings in AdMob plugin and PermissionsUtil#129enfipy merged 7 commits intomanifest-permissionsfrom
enfipy merged 7 commits intomanifest-permissionsfrom
Conversation
enfipy
added a commit
that referenced
this pull request
Aug 4, 2022
* Bump android manifest version and replace Cargo.toml metadata * [errors] Alter commands, refactor * Alter assets folders * Alter build targets * Alter docs, add Android and iOS strategies, fix test * Fix iOS icons bug, alter icons and splash screen, fix iOS Info.plist build, fix other issues * Fix cargo metadata test * Refacto android command * Fix macroquad permissions, refactor errors, remove redundant code * Fix warnings in AdMob plugin and PermissionsUtil (#129) * Fix warning * Fix warning * Fix warning * Merg and fix warning * Add comments what to replace * Fix warning permissions util * Add cross-platform permission API in Metadata * Fix CI build * Bump versions * Bump version of apple-bundle * Small doc fix * Reorganize tools structure (#132) * Reorganize tools structure * Downgrade bundletool version * Fix import Co-authored-by: David Ackerman <enfipy@gmail.com> * Alter description and move rustfmt * Fix fmt * Remove log command and add log flag * Fixes #130, fixes some warnings in AdMob and Crossbow Android * Closes #102, alter folders in crossbundle-tools, alter features * Add icon tmp solution * Remove icons to fix CI * Update some documentation Co-authored-by: zupaazmul <78680636+Adoka3710@users.noreply.github.com> Co-authored-by: Daniil Anikin <81761954+Heezay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This PR fixes some warnings in the Kotlin code for
AdMobAndroid andPermissionsUtil.