Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intel's
sin(x)is very inaccurate for|x| ≈ π/2, which leads to issues such as #4861.This is an attempt to work around the problem by implementing a custom sin/cos implementation using a Taylor approximation within a range of
[-π/4,π/4], and doing some magic to map the rest of the curve to that interval. Precision is good enough to meet D3D11 requirements and should fix Thumper, but this is expected to be quite slow.On systems with good sin/cos, keep using the corresponding SPIR-V instructions.
Needs testing across a reasonably wide range of games including D3D11, this changes code gen in all shaders that use
sincosinstructions even if the workaround is not used.