feat(katana): add fact registry arg for init - #404
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cwkang1998
changed the title
init(https://github.com/dojoengine/dojo/pull/3158)init (dojoengine/dojo#3158)
cwkang1998
changed the title
init (dojoengine/dojo#3158)init (https://github.com/dojoengine/dojo/pull/3158)
cwkang1998
changed the title
init (https://github.com/dojoengine/dojo/pull/3158)init
| --settlement-chain <Sepolia|Mainnet> \ | ||
| --settlement-account-address <ADDRESS> \ | ||
| --settlement-account-private-key <PRIVATE_KEY> | ||
| --settlement-facts-registry-contract <ADDRESS> |
There was a problem hiding this comment.
This is not something that is supported at the moment.
A custom option is present but may need more work to be functional.
You can however change your facts registry address directly on the deployed contract to use a mocked one for instance while developing. This can be directly changed calling the entrypoint set_facts_registry of Piltover.
There was a problem hiding this comment.
Ah @glihm I am submitting this PR specifically for dojoengine/dojo#3158, of course only merged when it is accepted. The PR adds support for this feature.
I currently find this the only location that actually documents the init behaviour for katana cli, that's why I added this.
Sorry if I misunderstood the contribution flow, should I have waited the PR on the dojo side to be merged first?
There was a problem hiding this comment.
All good, thanks for clarifying it. I didn't see any description so wasn't sure about the focus.
Appreciate your comment and the proposal on Dojo. 👍
There was a problem hiding this comment.
Sorry if I misunderstood the contribution flow, should I have waited the PR on the dojo side to be merged first?
Np np, yeah at least the link to the PR in dojo would have made the direct link (I've updated the description). 👍
4170fd6 to
37fff95
Compare
3 participants
Related to dojoengine/dojo#3158.