feat(katana): support raw chain id - #2276
Closed
greged93 wants to merge 2 commits into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2276 +/- ##
==========================================
- Coverage 70.29% 70.27% -0.02%
==========================================
Files 342 342
Lines 45094 45108 +14
==========================================
+ Hits 31698 31699 +1
- Misses 13396 13409 +13 ☔ View full report in Codecov by Sentry. |
glihm
marked this pull request as draft
August 8, 2024 19:29
Contributor
Member
|
@Eikix im workin on this rn, i've identified why it still failing, just gonna add some more test now |
Contributor
<3333 okk thx |
kariy
marked this pull request as ready for review
October 23, 2024 15:16
Member
Member
kariy
marked this pull request as draft
October 23, 2024 15:31
Contributor
|
Will close since it's blockifier dependent, the issue will remain open. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is made in other to provide a failing example for issue #1595.
Commit on blockifier which implemented the feature: dojoengine/sequencer@07f473f
Related issue
#1595
Tests
Added to documentation?
Checklist
scripts/prettier.sh,scripts/rust_fmt.sh,scripts/cairo_fmt.sh)scripts/clippy.sh,scripts/docs.sh)Summary by CodeRabbit
New Features
cairo-vm-test-utilsfor enhanced testing capabilities.GetChainIdto retrieve the chain ID within the StarkNet environment.Bug Fixes
Documentation
read_compiled_class_artifactfunction to clarify its purpose.Chores
GetChainIdcontract.