refactor(torii): abstract out how to format felts to avoid bugs - #2444
Merged
Conversation
itzlambda
force-pushed
the
spr/main/d618e874
branch
from
September 18, 2024 15:05
5457cc5 to
a212e36
Compare
glihm
approved these changes
Sep 19, 2024
glihm
left a comment
glihm
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this refactoring, useful to avoid too much strings to update in case of changes.
| } | ||
|
|
||
| pub(crate) fn felt_to_sql_string(felt: &Felt) -> String { | ||
| format!("{:#x}", felt) |
Contributor
There was a problem hiding this comment.
We should perhaps have a function with padding and one without padding? Or we always use without padding?
Author
There was a problem hiding this comment.
yeah for felt we where not padding previously so i kept the same behaviour
itzlambda
force-pushed
the
spr/main/5231a946
branch
from
September 19, 2024 09:40
d53a2e4 to
fc56768
Compare
itzlambda
force-pushed
the
spr/main/d618e874
branch
2 times, most recently
from
September 19, 2024 09:41
a97288c to
6f1f5a4
Compare
itzlambda
force-pushed
the
spr/main/5231a946
branch
from
September 19, 2024 09:41
fc56768 to
83ac6d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spr/main/5231a946 #2444 +/- ##
====================================================
Coverage ? 67.57%
====================================================
Files ? 370
Lines ? 48574
Branches ? 0
====================================================
Hits ? 32822
Misses ? 15752
Partials ? 0 ☔ View full report in Codecov by Sentry. |
itzlambda
force-pushed
the
spr/main/5231a946
branch
from
September 19, 2024 15:00
83ac6d1 to
3414843
Compare
itzlambda
force-pushed
the
spr/main/d618e874
branch
from
September 19, 2024 15:00
6f1f5a4 to
12df212
Compare
This was referenced Sep 19, 2024
itzlambda
force-pushed
the
spr/main/5231a946
branch
from
September 22, 2024 18:39
3414843 to
49e97bd
Compare
itzlambda
force-pushed
the
spr/main/d618e874
branch
2 times, most recently
from
September 23, 2024 06:29
33deeb3 to
7efbca3
Compare
itzlambda
force-pushed
the
spr/main/5231a946
branch
from
September 23, 2024 06:29
49e97bd to
ade93c2
Compare
commit-id:d618e874
itzlambda
force-pushed
the
spr/main/d618e874
branch
from
September 24, 2024 11:38
7efbca3 to
cbedcce
Compare
itzlambda
force-pushed
the
spr/main/5231a946
branch
from
September 24, 2024 11:38
ade93c2 to
49af8d1
Compare
commit-id:10465a00
commit-id:3bfe5955
commit-id:923dbba6
- cleanup plus other refactor for the PR stack - `start_block` configuration removed since it was no longer necessary now that we use `get_events` for `sync_range` - use debug log level transfer events commit-id:4acad5f3
commit-id:c6195721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: