refactor(torii-indexer): add token contract address to task identifier

[Larkooo]

Summary by CodeRabbit

• Refactor
  • Enhanced the transfer processing by updating how unique task identifiers are computed. The system now uses the sender’s address to generate the identifier, ensuring more consistent grouping of transfers across token types.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 57.03%. Comparing base (870087b) to head (ff105d2).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...ii/indexer/src/processors/erc20_legacy_transfer.rs	0.00%	2 Missing ⚠️
...tes/torii/indexer/src/processors/erc20_transfer.rs	0.00%	2 Missing ⚠️
...i/indexer/src/processors/erc721_legacy_transfer.rs	0.00%	2 Missing ⚠️
...es/torii/indexer/src/processors/erc721_transfer.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2985   +/-   ##
=======================================
  Coverage   57.02%   57.03%           
=======================================
  Files         427      427           
  Lines       56556    56556           
=======================================
+ Hits        32253    32254    +1     
+ Misses      24303    24302    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Ohayo sensei!

Walkthrough

This pull request updates the task_identifier methods in both ERC20 and ERC721 transfer processors (legacy and current). In each case, the code now hashes the event’s from_address instead of the previously used event key (i.e., the "Transfer" key). The rest of the identifier generation logic, including the computation of a canonical representation, remains unchanged.

Changes

File(s) Changed	Summary
crates/torii/.../erc20_legacy_transfer.rs crates/torii/.../erc20_transfer.rs	Updated task_identifier to hash from_address instead of the event key "Transfer" for ERC20 transfers.
crates/torii/.../erc721_legacy_transfer.rs crates/torii/.../erc721_transfer.rs	Updated task_identifier to hash from_address instead of the event key "Transfer" for ERC721 transfers.

Sequence Diagram(s)

sequenceDiagram
    participant E as Event
    participant P as Processor
    participant H as Hasher

    E->>P: Call task_identifier(event)
    P->>H: Hash event.from_address
    H-->>P: Return TaskId
    P-->>E: Return TaskId

Loading

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 870087b and ff105d2.

📒 Files selected for processing (4)

• crates/torii/indexer/src/processors/erc20_legacy_transfer.rs (1 hunks)
• crates/torii/indexer/src/processors/erc20_transfer.rs (1 hunks)
• crates/torii/indexer/src/processors/erc721_legacy_transfer.rs (1 hunks)
• crates/torii/indexer/src/processors/erc721_transfer.rs (1 hunks)

🔇 Additional comments (8)

crates/torii/indexer/src/processors/erc20_transfer.rs (2)

46-47: Ohayo! The change to use contract address in task identifier looks good, sensei!

Using from_address instead of event key provides better task isolation per contract.

---

49-54: Appreciate maintaining the canonical pair logic, sensei!

The canonical representation ensures consistent task grouping for bi-directional transfers between the same addresses.

crates/torii/indexer/src/processors/erc20_legacy_transfer.rs (2)

46-47: Ohayo! The legacy implementation aligns perfectly with the current one, sensei!

The change to use from_address maintains consistency with the non-legacy implementation.

---

49-54: Nice canonical pair implementation, sensei!

The logic for grouping related transfers remains intact and matches the current implementation.

crates/torii/indexer/src/processors/erc721_transfer.rs (2)

46-47: Ohayo! The ERC721 implementation follows the same pattern, sensei!

Using from_address aligns with the ERC20 implementations while maintaining NFT-specific behavior.

---

55-61: Excellent parallelization strategy for NFTs, sensei!

The token ID-based parallelization ensures:

1. Different tokens transfer in parallel
2. Same token transfers remain sequential
3. Related transfers stay grouped

crates/torii/indexer/src/processors/erc721_legacy_transfer.rs (2)

46-47: Ohayo! The legacy NFT implementation maintains consistency, sensei!

The change to use from_address aligns with all other implementations.

---

55-61: Great to see the NFT parallelization logic preserved, sensei!

The token ID-based task separation ensures optimal processing while maintaining safety.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.