Skip to content

chore(devcontainer): update image: 92422db - #3105

Merged
glihm merged 1 commit into
mainfrom
bump-devcontainer
Mar 14, 2025
Merged

chore(devcontainer): update image: 92422db#3105
glihm merged 1 commit into
mainfrom
bump-devcontainer

Conversation

@tarrencev

@tarrencev tarrencev commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

This release improves our infrastructure by updating the container environments used across our development, testing, and release pipelines. These behind‐the‐scenes enhancements help streamline processes and ensure greater consistency and reliability in our operations.

  • Chores
    • Upgraded container environments across internal workflows to a new, stable image version.

@coderabbitai

coderabbitai Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Ohayo, sensei! This PR updates the Docker image reference across multiple configuration files. The image tag for the development container and GitHub Actions workflows has been changed from a versioned tag (or loosely defined tag) to a specific commit hash (92422db). The modifications affect the .devcontainer/devcontainer.json file and several workflow files, ensuring consistency in the container environment across different jobs.

Changes

File(s) Change Summary
.devcontainer/devcontainer.json Updated Docker image reference from ghcr.io/dojoengine/dojo-dev:v1.2.2 to ghcr.io/dojoengine/dojo-dev:92422db.
.github/workflows/bench.yml, .github/.../ci.yml,
.github/.../release-dispatch.yml
Replaced old Docker image tags (v1.2.2 or bun) with commit hash 92422db in various jobs, aligning the container version across CI, bench, and release workflows.

Possibly related PRs

Suggested reviewers

  • glihm

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92422db and 6c315e3.

📒 Files selected for processing (4)
  • .devcontainer/devcontainer.json (1 hunks)
  • .github/workflows/bench.yml (2 hunks)
  • .github/workflows/ci.yml (6 hunks)
  • .github/workflows/release-dispatch.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: build-and-push
🔇 Additional comments (10)
.github/workflows/release-dispatch.yml (1)

17-17: Ohayo, sensei!
The container image has been updated to ghcr.io/dojoengine/dojo-dev:92422db, which aligns with our consistency goals across workflows.

.devcontainer/devcontainer.json (1)

5-5: Ohayo, sensei!
The Docker image reference is now set to ghcr.io/dojoengine/dojo-dev:92422db. This update brings our development container in line with the CI environment. Great work keeping things consistent!

.github/workflows/ci.yml (6)

18-18: Ohayo, senseai!
The build job's container image has been updated to use ghcr.io/dojoengine/dojo-dev:92422db, ensuring that builds run against the intended environment.


45-45: Nice one, sensei!
The test job now uses the updated Docker image, which will help maintain consistency across our CI pipeline.


76-76: Ohayo, sensei!
The ensure-wasm job has been updated to use the new Docker image ghcr.io/dojoengine/dojo-dev:92422db. This consistency is key for reproducible builds.


185-185: Great update, sensei!
The container image for the clippy job is now updated to the specific commit hash, which should ensure our linting runs in the correct environment.


199-199: Ohayo, sensei!
The fmt job container image has been updated to ghcr.io/dojoengine/dojo-dev:92422db, supporting consistent formatting checks.


209-209: Nice update, sensei!
The docs job is also now running with the updated container image, ensuring that document generation occurs with the correct dependencies.

.github/workflows/bench.yml (2)

17-17: Ohayo, sensei!
The bench-katana job now uses the Docker image ghcr.io/dojoengine/dojo-dev:92422db, ensuring that benchmark runs are based on the updated container environment.


39-39: Great update, sensei!
The bench-sozo job's container image has been updated accordingly. This change keeps our benchmarking environments uniformly configured.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov

codecov Bot commented Mar 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.10%. Comparing base (92422db) to head (6c315e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3105   +/-   ##
=======================================
  Coverage   57.10%   57.10%           
=======================================
  Files         442      442           
  Lines       61035    61035           
=======================================
  Hits        34857    34857           
  Misses      26178    26178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants