Skip to content

chore(devcontainer): update image: v1.3.0 - #3109

Merged
glihm merged 1 commit into
mainfrom
bump-devcontainer
Mar 18, 2025
Merged

chore(devcontainer): update image: v1.3.0#3109
glihm merged 1 commit into
mainfrom
bump-devcontainer

Conversation

@tarrencev

@tarrencev tarrencev commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • Chores
    • Updated the container image version to v1.3.0 across development, testing, benchmarking, and release processes to ensure enhanced consistency and stability in our environment.

@coderabbitai

coderabbitai Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Ohayo, sensei!

Walkthrough

This pull request updates the Docker image reference used in both the development container configuration and several GitHub Actions workflows. The image tag is changed from 92422db to v1.3.0, affecting Rust development, benchmarking, testing, and release processes without altering any job logic.

Changes

File(s) Change Summary
.devcontainer/devcontainer.json Updated Docker image from ghcr.io/dojoengine/dojo-dev:92422db to ghcr.io/dojoengine/dojo-dev:v1.3.0.
.github/workflows/bench.yml, .github/workflows/ci.yml, .github/workflows/release-dispatch.yml Docker image tag updated to v1.3.0 for all defined jobs, replacing the old 92422db tag in benchmarking, CI, and release workflows.

Possibly related PRs

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e470247 and 4d4002b.

📒 Files selected for processing (4)
  • .devcontainer/devcontainer.json (1 hunks)
  • .github/workflows/bench.yml (2 hunks)
  • .github/workflows/ci.yml (6 hunks)
  • .github/workflows/release-dispatch.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (10)
.github/workflows/release-dispatch.yml (1)

17-17: Ohayo, sensei! The updated container image looks solid.

The Docker image for the propose-release job has been updated to v1.3.0, which aligns perfectly with the new development container configuration. Excellent work keeping the versions consistent!

.github/workflows/bench.yml (2)

17-17: Ohayo, sensei! The bench-katana image update is on point.

The container image change to ghcr.io/dojoengine/dojo-dev:v1.3.0 ensures that the benchmarking environment for Katana is consistent with the updated dev container.


39-39: Hey sensei, the bench-sozo image update looks sharp!

Switching to v1.3.0 here brings the same consistency to the Sozo benchmarking job as well.

.devcontainer/devcontainer.json (1)

5-5: Ohayo, sensei! The devcontainer image update is correct.

Updating the Docker image to ghcr.io/dojoengine/dojo-dev:v1.3.0 ensures that your local development environment and CI build environments are in sync. Nice work!

.github/workflows/ci.yml (6)

18-18: Ohayo, sensei! The build job's container image upgrade looks superb.

The update to v1.3.0 for the build job aligns your build environment with the new standards, ensuring consistency.


45-45: Great update, sensei!

The test job now correctly uses the updated Docker image v1.3.0, which is key for consistency across CI jobs.


76-76: Ohayo, sensei! The ensure-wasm job's container image is up-to-date.

Using v1.3.0 here solidifies the uniformity across all your CI environments—nice and tidy!


185-185: Sensei, the clippy job’s container update is neat.

Changing the container image to v1.3.0 means your linting environment now preserves the same toolset as your other jobs.


199-199: Ohayo, sensei! The fmt job's update is crisp and consistent.

This update to v1.3.0 ensures that your code formatting checks run in a familiar environment.


209-209: Ohayo, sensei! The docs job container image change is on point.

The updated Docker image v1.3.0 guarantees that documentation builds are executed in the latest and consistent environment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov

codecov Bot commented Mar 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.09%. Comparing base (e470247) to head (4d4002b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
- Coverage   57.11%   57.09%   -0.02%     
==========================================
  Files         442      442              
  Lines       61199    61199              
==========================================
- Hits        34951    34941      -10     
- Misses      26248    26258      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@glihm
glihm merged commit 67ac7e1 into main Mar 18, 2025
@glihm
glihm deleted the bump-devcontainer branch March 18, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants