fix(Dockerfile): move dependencies in base image - #3173
Merged
Conversation
Contributor
WalkthroughOhayo sensei! This update modifies the Dockerfile by moving the installation of certain packages ( Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Dockerfile (1)
3-3: ohayo sensei! Standardize installer commands and cleanup in builder stage
The builder stage currently runsapt install -ywithout cleaning up caches or disabling recommendations. To shrink image layers and avoid extra packages, consider:- RUN apt-get update && apt install -y git libtool automake autoconf make + RUN apt-get update && \ + DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ + git libtool automake autoconf make && \ + rm -rf /var/lib/apt/lists/*This will reduce image size and prevent pulling in unnecessary recommended packages.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: x86_64-pc-windows-msvc (windows-latest)
- GitHub Check: aarch64-apple-darwin (macos-latest)
- GitHub Check: x86_64-apple-darwin (macos-latest-xlarge)
- GitHub Check: aarch64-unknown-linux-gnu (ubuntu-latest-8-cores-arm64)
- GitHub Check: x86_64-unknown-linux-gnu (ubuntu-latest-8-cores)
- GitHub Check: build
Moved installation of curl, ca-certificates, and tini to the base image stage. Cleaned up apt cache to reduce image size.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
- Coverage 55.62% 55.62% -0.01%
==========================================
Files 443 443
Lines 62987 62987
==========================================
- Hits 35038 35034 -4
- Misses 27949 27953 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ensure tini is copied to a new path and update the entrypoint accordingly to prevent runtime issues.
kariy
pushed a commit
that referenced
this pull request
Apr 21, 2025
* fix(Dockerfile): move dependencies in base image Moved installation of curl, ca-certificates, and tini to the base image stage. Cleaned up apt cache to reduce image size. * fix(Dockerfile): adjust tini installation and entrypoint path Ensure tini is copied to a new path and update the entrypoint accordingly to prevent runtime issues.
kariy
pushed a commit
that referenced
this pull request
Apr 28, 2025
* fix(Dockerfile): move dependencies in base image Moved installation of curl, ca-certificates, and tini to the base image stage. Cleaned up apt cache to reduce image size. * fix(Dockerfile): adjust tini installation and entrypoint path Ensure tini is copied to a new path and update the entrypoint accordingly to prevent runtime issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved installation of curl, ca-certificates, and tini to the base image stage. Cleaned up apt cache to reduce image size.
Summary by CodeRabbit