Fix assert caller permission

[remybar]

Description

Since Starknet 0.13.4, it is now possible to manage call_contract_syscall() result using a match.
This PR updates the panic_with_details() world function to have a better panic trace.

This PR also updates spawn-and-move tests to not use 0 as caller address as it is the default caller address.

Tests

• Yes
• No, because they aren't needed
• No, because I need help

Added to documentation?

• README.md
• Dojo Book
• No documentation needed

Checklist

• I've formatted my code (scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
• I've linted my code (scripts/clippy.sh, scripts/docs.sh)
• I've commented my code
• I've requested a review after addressing the comments

Summary by CodeRabbit

• Tests

  • Updated expected error messages in multiple test cases to use hexadecimal contract addresses and more descriptive permission-denied messages.
  • Improved clarity and consistency of panic messages across access control, contract, event, metadata, model, and world-related tests.
  • Adjusted test attributes and formatting for better readability.
  • Modified example test setups to use a consistent caller address and properly configure the testing environment.

• Style

  • Enhanced formatting of error messages to consistently display contract addresses in hexadecimal format.
  • Refined contract caller identification logic to improve error message accuracy and avoid assumptions.

• Chores

  • Temporarily disabled runtime spec version checks to improve compatibility with multiple networks.

[coderabbitai]

"""

Walkthrough

Ohayo sensei! This update revises expected panic messages across multiple test files to use explicit, descriptive error strings with hexadecimal addresses, enhancing clarity around access control failures. It also adjusts error formatting in the core world contract logic to match these changes, but does not alter any test logic or exported interfaces.

Changes

File(s)	Change Summary
crates/dojo/core-cairo-test/src/tests/world/acl.cairo contract.cairo event.cairo metadata.cairo model.cairo world.cairo	Updated expected panic messages in tests to use explicit, descriptive error strings with hexadecimal addresses. Reformatted panic attributes for consistency.
crates/dojo/core/src/world/world_contract.cairo	Changed error formatting in panic_with_details to use hexadecimal addresses and improved contract name resolution logic.
examples/spawn-and-move/src/actions.cairo	Changed test caller address from 0x0 to 0xb0b and set contract address in test environment for consistency.
bin/sozo/src/utils.rs	Disabled runtime RPC spec version check by commenting it out; renamed constant to mark unused; suppressed dead code warning on version compatibility function.
examples/spawn-and-move/dojo_dev.toml	Updated world_address value in configuration to a new address.

Sequence Diagram(s)

sequenceDiagram
    participant TestCase
    participant WorldContract
    participant Syscall
    participant DojoContract

    TestCase->>WorldContract: Call restricted function as non-owner/writer
    WorldContract->>Syscall: call_contract_syscall("dojo_name")
    alt Syscall returns Ok
        Syscall-->>WorldContract: Contract name (serialized)
        WorldContract->>WorldContract: Deserialize and format error message
    else Syscall returns Error
        Syscall-->>WorldContract: Error
        WorldContract->>WorldContract: Fallback to hex address in error message
    end
    WorldContract-->>TestCase: Panic with descriptive error string

Loading

Possibly related PRs

• fix: improve world's error messages #2305: Refines error handling and access control feedback in the world contract and tests, closely related to these error message updates.
• fix(dojo-core): adjust ACL to restore governance without relaxing permissions #2341: Modifies ACL permission checks and caller validation logic, corresponding to the permission model reflected in the updated test messages.
  """

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1efdf1f and 1e3d154.

⛔ Files ignored due to path filters (1)

• spawn-and-move-db.tar.gz is excluded by !**/*.gz

📒 Files selected for processing (1)

• examples/spawn-and-move/dojo_dev.toml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• examples/spawn-and-move/dojo_dev.toml

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: fmt

✨ Finishing Touches

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch fix-assert_caller_permission

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5a38e3 and 1efdf1f.

📒 Files selected for processing (1)

• bin/sozo/src/utils.rs (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: fmt

🔇 Additional comments (2)

bin/sozo/src/utils.rs (2)

35-35: Ohayo sensei! Good practice marking unused constant.

The underscore prefix properly indicates this constant is temporarily unused, following Rust conventions.

---

235-235: Ohayo sensei! Proper dead code handling.

Good practice using #[allow(dead_code)] to suppress warnings for the temporarily unused function rather than removing it, since it will be needed when the version check is re-enabled.

[coderabbitai]

🛠️ Refactor suggestion

Temporary workaround creates deployment risk, sensei.

While commenting out the version compatibility check solves the immediate Katana deployment issue, this removes an important safety guard that prevents incompatible RPC versions from being used, potentially causing runtime failures on production networks.

Consider implementing a more targeted solution:

-    // TODO: @remybar @glihm currently Katana is using new types, but doesn't
-    // return the correct spec version. We comment this test for now to ensure
-    // one can deploy on sepolia/mainnet but also Katana.
-    //     if !is_compatible_version(&spec_version, RPC_SPEC_VERSION)? {
-    // return Err(anyhow!(
-    // "Unsupported Starknet RPC version: {}, expected {}.",
-    // spec_version,
-    // RPC_SPEC_VERSION
-    // ));
-    // }
+    // Skip version check for Katana (known compatibility issue in 0.13.4)
+    let is_katana = chain_id.contains("KATANA") || spec_version.contains("katana");
+    if !is_katana && !is_compatible_version(&spec_version, _RPC_SPEC_VERSION)? {
+        return Err(anyhow!(
+            "Unsupported Starknet RPC version: {}, expected {}.",
+            spec_version,
+            _RPC_SPEC_VERSION
+        ));
+    }

This maintains safety for production networks while allowing Katana deployments.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents

In bin/sozo/src/utils.rs around lines 157 to 166, the version compatibility
check is commented out as a temporary workaround, which removes an important
safety guard. To fix this, implement a conditional check that skips the
compatibility verification only when deploying on Katana, but enforces it on
sepolia/mainnet and other production networks. This approach maintains safety by
preventing incompatible RPC versions in production while allowing Katana
deployments.

[glihm]

Thank you @remybar!