chore: add Katana 1.6.2 - #3280
Merged
Merged
Conversation
Contributor
WalkthroughOhayo sensei! This update modifies the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
32
to
34
| "1.6.0-alpha.0": { | ||
| "katana": ["1.6.1", "1.6.0", "1.6.0-alpha.1", "1.6.0-alpha.0"], | ||
| "katana": ["1.6.2", "1.6.1", "1.6.0", "1.6.0-alpha.1", "1.6.0-alpha.0"], | ||
| "torii": [ |
Contributor
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Ohayo sensei! Verify that Katana 1.6.2 is published and no duplicate slips in
Great to see the latest patch added, but before merge please double-check that:
- The
katana1.6.2 artifact is actually available in the registry you deploy from. - Each list remains de-duplicated and ordered newest → oldest.
You can run this quick sanity script from the repo root:
Also applies to: 48-49, 63-64
🏁 Script executed:
#!/bin/bash
# Validate availability (replace the URL/tool if you host Katana elsewhere)
curl -sfI "https://pypi.org/pypi/katana/1.6.2/json" || {
echo "❌ katana 1.6.2 not found on PyPI"; exit 1;
}
# Detect accidental duplicates across the three updated arrays
jq '
["1.6.0-alpha.0","1.6.0-alpha.1","1.6.0-alpha.2"]
| map(.[].katana) as $lists
| ($lists | flatten) as $all
| if ($all | unique | length) != ($all | length)
then "❌ duplicate katana versions detected"
else "✅ no duplicates"
end' versions.jsonLength of output: 3020
❌ Ohayo sensei! Katana 1.6.2 isn’t published on PyPI yet – please publish before merging
It looks like our sanity check failed:
curl -sfI https://pypi.org/pypi/katana/1.6.2/jsonreturns 404- The duplicate-check script didn’t run because we exited early
Please address the following before we can approve:
• Publish the Katana 1.6.2 artifact to your registry (e.g. PyPI).
curl -sfI https://pypi.org/pypi/katana/1.6.2/json \
&& echo "✅ katana 1.6.2 is live" \
|| { echo "❌ katana 1.6.2 not found – publish it first"; exit 1; }• Re-run the duplicate-detection across all version arrays to ensure no slipped-in duplicates and that lists remain sorted newest→oldest.
Once Katana 1.6.2 is live and there are no duplicates, we’re good to merge!
🤖 Prompt for AI Agents
In versions.json around lines 32 to 34, the version "1.6.2" of Katana is listed
but not yet published on PyPI, causing a 404 error during the sanity check.
First, publish the Katana 1.6.2 artifact to PyPI or your package registry. After
confirming it is live by checking the URL, re-run the duplicate detection script
on all version arrays to ensure there are no duplicates and that the versions
are sorted from newest to oldest before merging.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit