Skip to content

chore: bump katana-runner rev - #3320

Merged
kariy merged 1 commit into
mainfrom
bumpkatana
Sep 1, 2025
Merged

chore: bump katana-runner rev#3320
kariy merged 1 commit into
mainfrom
bumpkatana

Conversation

@kariy

@kariy kariy commented Sep 1, 2025

Copy link
Copy Markdown
Member

ref #3293

The rpc/v0.9 branch has been deleted on the dojoengine/katana repo but it's been merged to the main branch. This rev belongs to the main branch.

@coderabbitai

coderabbitai Bot commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

ohayo, sensei!

Walkthrough

Pinned the katana-runner dependency in Cargo.toml from a branch reference (rpc/v0.9) to a specific commit (rev eba352a) using the same Git URL. No other files or code paths are changed.

Changes

Cohort / File(s) Summary
Dependency pinning
Cargo.toml
Changed katana-runner dependency from { git = "https://github.com/dojoengine/katana", branch = "rpc/v0.9" } to { git = "https://github.com/dojoengine/katana", rev = "eba352a" }.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bumpkatana

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
Cargo.toml (2)

88-90: Prefer full 40-char SHA for the rev.

Short prefixes can collide across forks/remotes. Use the full commit hash and optionally add a comment with why it’s pinned to aid future bumps.

-katana-runner = { git = "https://github.com/dojoengine/katana", rev = "eba352a" }
+# Pinned for rpc 0.9 compatibility; update alongside torii/slot bumps.
+katana-runner = { git = "https://github.com/dojoengine/katana", rev = "<FULL_40_CHAR_SHA>" }

88-90: Audit other moving git deps for consistency.

You still have other branch-based git deps (e.g., slot on feat/rpc0.9). Consider pinning them in a follow-up to avoid drift between CI and local builds.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d783563 and 135d5ad.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: fmt
🔇 Additional comments (2)
Cargo.toml (2)

88-90: Ohayo, sensei — good call pinning to a commit for reproducibility.

Moving from a branch to a fixed rev removes non-determinism in builds. Looks clean.


88-90: Manual verification required: katana-runner dependency
Ohayo sensei — the sandbox env couldn’t run cargo metadata (error: no /proc/self/exe), so we can’t confirm the eba352a rev or dependency tree here. Please run the original verification script locally and ensure that commit exists upstream and that exactly one katana-runner version is resolved.

@kariy
kariy merged commit c47aad4 into main Sep 1, 2025
10 checks passed
@kariy
kariy deleted the bumpkatana branch September 1, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant