chore: bump katana-runner rev - #3320
Conversation
|
ohayo, sensei! WalkthroughPinned the katana-runner dependency in Cargo.toml from a branch reference (rpc/v0.9) to a specific commit (rev eba352a) using the same Git URL. No other files or code paths are changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Cargo.toml (2)
88-90: Prefer full 40-char SHA for therev.Short prefixes can collide across forks/remotes. Use the full commit hash and optionally add a comment with why it’s pinned to aid future bumps.
-katana-runner = { git = "https://github.com/dojoengine/katana", rev = "eba352a" } +# Pinned for rpc 0.9 compatibility; update alongside torii/slot bumps. +katana-runner = { git = "https://github.com/dojoengine/katana", rev = "<FULL_40_CHAR_SHA>" }
88-90: Audit other moving git deps for consistency.You still have other branch-based git deps (e.g.,
slotonfeat/rpc0.9). Consider pinning them in a follow-up to avoid drift between CI and local builds.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: fmt
🔇 Additional comments (2)
Cargo.toml (2)
88-90: Ohayo, sensei — good call pinning to a commit for reproducibility.Moving from a branch to a fixed
revremoves non-determinism in builds. Looks clean.
88-90: Manual verification required: katana-runner dependency
Ohayo sensei — the sandbox env couldn’t runcargo metadata(error: no /proc/self/exe), so we can’t confirm theeba352arev or dependency tree here. Please run the original verification script locally and ensure that commit exists upstream and that exactly onekatana-runnerversion is resolved.
ref #3293
The
rpc/v0.9branch has been deleted on thedojoengine/katanarepo but it's been merged to the main branch. This rev belongs to the main branch.