chore: update to katana-compatible snos - #6
Merged
Merged
Conversation
kariy
marked this pull request as draft
January 29, 2025 23:40
glihm
changed the title
katana-compatible snos (don't merge yet)katana-compatible snos
glihm
marked this pull request as ready for review
February 1, 2025 22:14
Contributor
|
To have this revision of SNOS working, Katana must be started by doing the following:
|
xJonathanLEI
reviewed
Feb 3, 2025
glihm
reviewed
Feb 7, 2025
| // Since the `Felt` type is wrapping (`Felt::MAX + 1 = 0`), there is not | ||
| // need for a special case for the genesis block, and `+1` works as expected. | ||
| // | ||
| // TODO: should we change to `settlement.next_block_number()` instead to always return `u64`? |
Contributor
There was a problem hiding this comment.
@xJonathanLEI I would tend to add the new method, or always manipulating the block number as a Felt, wdyt?
Contributor
|
Tested on Katana dojoengine/dojo#2980 with verification on Sepolia (layout bridge mocked). |
glihm
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to our fork of
snos. This version only works with the latest provable version ofkatana.