Skip to content

Split gRPC supported platforms doc into hosting services and calling services sections - #21689

Merged
JamesNK merged 7 commits into
mainfrom
jamesnk/grpc-supported-platforms-v2
Mar 11, 2021
Merged

Split gRPC supported platforms doc into hosting services and calling services sections#21689
JamesNK merged 7 commits into
mainfrom
jamesnk/grpc-supported-platforms-v2

Conversation

@JamesNK

@JamesNK JamesNK commented Mar 4, 2021

Copy link
Copy Markdown
Member

Split the gRPC supported platform doc into two sections: one for hosting services and another for calling services.

Internal previews:


Comment thread aspnetcore/grpc/supported-platforms.md Outdated
Comment thread aspnetcore/grpc/supported-platforms.md Outdated
@Rick-Anderson

Copy link
Copy Markdown
Contributor

Verified all new links.

@JamesNK
JamesNK force-pushed the jamesnk/grpc-supported-platforms-v2 branch from 6e15028 to 204ae8f Compare March 5, 2021 02:46
@JamesNK
JamesNK requested a review from Rick-Anderson March 5, 2021 02:48
@JamesNK

JamesNK commented Mar 5, 2021

Copy link
Copy Markdown
Member Author

@Rick-Anderson I've made some substantial changes and split a section into a new doc. Please re-review 🙏

@Rick-Anderson Rick-Anderson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions

Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
Comment thread aspnetcore/grpc/netstandard.md Outdated
@JamesNK JamesNK added the blocked label Mar 5, 2021
@JamesNK

JamesNK commented Mar 5, 2021

Copy link
Copy Markdown
Member Author

Looks good. Will wait until gRPC release before merging. Should be next week.

@Rick-Anderson
Rick-Anderson marked this pull request as draft March 5, 2021 05:48

@Rick-Anderson Rick-Anderson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 3.1

Comment thread aspnetcore/grpc/supported-platforms.md
Comment thread aspnetcore/grpc/supported-platforms.md Outdated
Comment thread aspnetcore/grpc/supported-platforms.md Outdated
@JamesNK
JamesNK force-pushed the jamesnk/grpc-supported-platforms-v2 branch from e9a0bef to ed4f620 Compare March 8, 2021 04:46
@JamesNK
JamesNK merged commit 2a813f9 into main Mar 11, 2021
@JamesNK
JamesNK deleted the jamesnk/grpc-supported-platforms-v2 branch March 11, 2021 02:10
@scottaddie scottaddie changed the title Improve gRPC supported platforms doc Split gRPC supported platforms doc into hosting services and calling services sections Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants