Skip to content

Kestrel diagnostics doc - #23319

Merged
Rick-Anderson merged 7 commits into
mainfrom
shirhatti/kestrel-diagnostics
Sep 18, 2021
Merged

Kestrel diagnostics doc#23319
Rick-Anderson merged 7 commits into
mainfrom
shirhatti/kestrel-diagnostics

Conversation

@shirhatti

@shirhatti shirhatti commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md
@Rick-Anderson

Copy link
Copy Markdown
Contributor

@Rick-Anderson Does the anchor tag not work on xref links? I want to link to a section of the doc.

Yes it does. You were missing /index on one suggestion I made, but I left the anchor.

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel/endpoints?view=aspnetcore-5.0#connection-logging
Should one of them be removed or abbreviated and linked to the other?

abbreviate it if you want to keep it.

Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
Comment thread aspnetcore/fundamentals/servers/kestrel/diagnostics.md Outdated
shirhatti and others added 3 commits September 16, 2021 11:31
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Aditya Mandaleeka <adityamandaleeka@users.noreply.github.com>
@shirhatti
shirhatti marked this pull request as ready for review September 17, 2021 23:07
@shirhatti

Copy link
Copy Markdown
Contributor Author

@Rick-Anderson Good to merge?

@Rick-Anderson
Rick-Anderson merged commit 0019a56 into main Sep 18, 2021
@Rick-Anderson
Rick-Anderson deleted the shirhatti/kestrel-diagnostics branch September 18, 2021 00:01
@Rick-Anderson

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5.0 docs: Kestrel event counters Document selective logging with Kestrel subcategories

4 participants