Fix | Adding type convertor support for SqlConnectionEncryptOption#2057
Merged
Kaur-Parminder merged 25 commits intoJul 6, 2023
Conversation
…t string Encrypt option into SqlConnectionEncryptionOption type.
JRahnama
reviewed
Jun 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
- Coverage 70.68% 69.89% -0.80%
==========================================
Files 305 306 +1
Lines 61819 61956 +137
==========================================
- Hits 43699 43302 -397
- Misses 18120 18654 +534
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
DavoudEshtehari
changed the title
…onStringBuilderTest.cs
…ThrowsException unit test.
Contributor
DavoudEshtehari
left a comment
DavoudEshtehari
left a comment
There was a problem hiding this comment.
The xml files are only required for public APIs. In this case, if SqlConnectionEncryptOptionConverter type is going to be internal, remove the xml file and inline dependencies.
…ptionConverter. Removed misplaced region. Removed function that is not used.
…vertFrom test returns false.
This reverts commit 06b3536.
…onvertTo returns false.
…vertTo tests passed or failed.
DavoudEshtehari
approved these changes
Jun 28, 2023
JRahnama
approved these changes
Jul 6, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Oct 25, 2023
…nnectionEncryptOption (dotnet#2057) Ports [dotnet#2057](dotnet#2057)
This was referenced Jul 30, 2025
This was referenced Apr 6, 2026
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1894
Added type converter for SqlConnectionEncryptOption.