Fix | Take out the ignoreSniOpenTimeout in open connection#2067
Merged
JRahnama merged 12 commits intoJul 20, 2023
Conversation
…t string Encrypt option into SqlConnectionEncryptionOption type.
… than not work?
…o convert string Encrypt option into SqlConnectionEncryptionOption type." This reverts commit 5c505a1.
…o convert string Encrypt option into SqlConnectionEncryptionOption type." This reverts commit 5c505a1.
… 15 less than not work?" This reverts commit cde0430.
Added Unit Test to prove that the ignore timeout has been removed.
arellegue
requested review from
David-Engel,
DavoudEshtehari,
JRahnama and
Kaur-Parminder
June 19, 2023 23:37
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2067 +/- ##
==========================================
+ Coverage 70.01% 70.67% +0.65%
==========================================
Files 306 306
Lines 61962 61975 +13
==========================================
+ Hits 43383 43800 +417
+ Misses 18579 18175 -404
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
JRahnama
marked this pull request as draft
June 20, 2023 17:18
Contributor
|
The original comment around this area of code is: It's not clear why anyone would want to ignore the specified timeout just from this comment. I would think users would want the ability to have a responsive timeout, so I'm inclined to be okay with "fixing" this issue. |
Kaur-Parminder
marked this pull request as ready for review
June 22, 2023 18:48
arellegue
changed the title
arellegue
changed the title
…out_-less_than_15_not_working
DavoudEshtehari
changed the title
DavoudEshtehari
changed the title
DavoudEshtehari
changed the title
DavoudEshtehari
left a comment
DavoudEshtehari
left a comment
Contributor
There was a problem hiding this comment.
Can you explain why you kept 'ignoreSniOpenTimeout' in netfx if you're not going to remove them?
DavoudEshtehari
approved these changes
Jul 12, 2023
JRahnama
approved these changes
Jul 20, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Jul 21, 2023
…otnet#2067)" This reverts commit 7314307. # Conflicts: # src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Jul 25, 2023
…ction (dotnet#2067)"" This reverts commit 02ffcb1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1126. The ignoreSniOpenTimeout was removed from all function calls in opening a connection as suggested.